Add N3LO ren SV #145
Merged
Add N3LO ren SV #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreab1997
reviewed
Dec 14, 2023
There was a problem hiding this comment.
Thanks for this. It looks ok (even if I need to have a more careful look). My only comment is that this function is only called to get one contribution, while in this way every time it needs to compute all the terms, while returning only one. This seems a waste to me.
True - but I'm sure we can afford the calculation of O(10) polynomials for the sake of clarity |
andreab1997
approved these changes
Dec 14, 2023
giacomomagni
requested changes
Dec 14, 2023
Co-authored-by: Giacomo Magni <[email protected]>
giacomomagni
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #144
I hope I did the correct thing 🙈 ... (unfortunately the module is not so clearly written ...) if you agree I can add a N3LO unit test